Skip to content

[github] fix for new PR review experience #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

[github] fix for new PR review experience #196

merged 1 commit into from
Aug 4, 2025

Conversation

filiptronicek
Copy link
Member

@filiptronicek filiptronicek commented Aug 4, 2025 •
edited
Loading

Description

As GitHub rolls out its new pull request review experience, we'll want our extension to support it. This PR addresses that

image

How to test

  1. Run the extension in dev mode (pnpm run dev) and install it unpacked in a Chromium-based browser
  2. Go to a PR on GitHub and click on the "Files changed" tab
  3. Make sure you're enrolled in the new experience (there should be a button on the PR review page to enroll)
  4. Observe the Gitpod button is present

@filiptronicek
Copy link
Member Author

filiptronicek commented Aug 4, 2025 •
edited
Loading

Tests are passing locally again, but I need to take a look at the CI builds at some point...

$ cd test && pnpm test

> [email protected] test /Users/filip/Documents/GitHub/browser-extension/test
> cp ../src/button/button-contributions.ts ./src/button-contributions-copy.ts && tsc && mocha dist/**/*.spec.js



  Platform match tests
    ✔ should detect the platform for https://gitlab.com/svenefftinge/browser-extension-test (896ms)
    ✔ should detect the platform for https://gitlab.com/svenefftinge/browser-extension-test/-/tree/my-branch (611ms)
    ✔ should detect the platform for https://gitlab.com/filiptronicek/empty (662ms)
    ✔ should detect the platform for https://gitlab.com/svenefftinge/browser-extension-test/-/merge_requests/1 (818ms)
    ✔ should detect the platform for https://gitlab.com/svenefftinge/browser-extension-test/-/issues/1 (707ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test (900ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/tree/my-branch (680ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/commit/82d701a9ac26ea25da9b24c5b3722b7a89e43b16 (576ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/issues/1 (839ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/issues/1 (153ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/pull/2 (542ms)
    ✔ should detect the platform for https://github.com/svenefftinge/browser-extension-test/blob/my-branch/README.md (451ms)
    ✔ should detect the platform for https://bitbucket.gitpod-dev.com/users/svenefftinge/repos/browser-extension-test/browse (339ms)
    ✔ should detect the platform for https://bitbucket.gitpod-dev.com/users/svenefftinge/repos/browser-extension-test/browse?at=refs%2Fheads%2Fmy-branch (145ms)
    ✔ should detect the platform for https://bitbucket.org/efftinge/browser-extension-test/commits/ (1257ms)

  Query Selector Tests
    ✔ url (https://gitlab.com/svenefftinge/browser-extension-test) should only match 'gl-repo' (918ms)
    ✔ url (https://gitlab.com/svenefftinge/browser-extension-test/-/tree/my-branch) should only match 'gl-repo' (615ms)
    ✔ url (https://gitlab.com/filiptronicek/empty) should only match 'gl-repo-empty' (759ms)
    ✔ url (https://gitlab.com/svenefftinge/browser-extension-test/-/merge_requests/1) should only match 'gl-merge-request' (802ms)
    ✔ url (https://gitlab.com/svenefftinge/browser-extension-test/-/issues/1) should only match 'gl-issue' (736ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test) should only match 'gh-repo' (482ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/tree/my-branch) should only match 'gh-repo' (218ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/commit/82d701a9ac26ea25da9b24c5b3722b7a89e43b16) should only match 'gh-commit' (265ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/issues/1) should only match 'gh-issue' (300ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/issues/1) should only match 'gh-issue-new' (165ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/pull/2) should only match 'gh-pull' (199ms)
    ✔ url (https://github.com/svenefftinge/browser-extension-test/blob/my-branch/README.md) should only match 'gh-file' (290ms)
    ✔ url (https://bitbucket.gitpod-dev.com/users/svenefftinge/repos/browser-extension-test/browse) should only match 'bbs-repo' (457ms)
    ✔ url (https://bitbucket.gitpod-dev.com/users/svenefftinge/repos/browser-extension-test/browse?at=refs%2Fheads%2Fmy-branch) should only match 'bbs-repo' (200ms)
    ✔ url (https://bitbucket.org/efftinge/browser-extension-test/commits/) should only match 'bb-commits' (1305ms)


  30 passing (19s)

@filiptronicek filiptronicek self-assigned this Aug 4, 2025
@filiptronicek filiptronicek merged commit 475dbd6 into main Aug 4, 2025
1 check failed
@filiptronicek filiptronicek deleted the ft/fix-for-new-gh-pr-review-exp branch August 4, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

Assignees

@filiptronicek filiptronicek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filiptronicek @Siddhant-K-code